add metadata for two authors; remove two duplicate commentaries#21
Merged
emeth- merged 3 commits intoJul 22, 2026
Conversation
Didymus of Alexandria is Didymus the Blind, who already has a folder in this repo -- the added metadata.toml was byte-identical to the existing Didymus the Blind/metadata.toml. Keeping both folders would emit two separate authors in father_meta (keyed on folder name, UNIQUE on name) and orphan the lone Wisdom 8:8 quote from the rest of his corpus. Its source_title cites PG 39, his volume. Moves the file into Didymus the Blind/ and drops the duplicate folder. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Fantastic catches, thanks for the PR! On review, I noticed Didymus of Alexandria is a dupe of the Didymus the Blind folder, so added a commit merging the two in your PR. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small data fixes I came across while building an offline SQLite pack from this
database for Scriptura (a native GNOME Bible app — the "Voices of the Church"
pane is built on your data, with your kind permission a while back):
metadata.tomlfor two author folders.python compile_data.py dryrunpasses with these changes.1. Missing
metadata.tomlTwo author folders had no
metadata.toml, so they fall back to nodefault_yearand no
father_category. Added both, with sources:Didymus of Alexandria → this is Didymus the Blind (c. 313 – 398), head of the
Alexandrian catechetical school; his one entry here (on Wisdom 8:8) is cited to
PG 39, which is his volume.
Sources: Catholic Encyclopedia,
Britannica.
Cerealis of Castellum Ripense → Latin North-African bishop, author of the
Libellus contra Maximinum Arianum; took part in the 484 Council of Carthage under
Huneric, treatise dated 485 (his entry here, on Wisdom 18:15, is from that work).
No English Wikipedia page, so I used the McClintock & Strong entry, consistent with
how other obscure figures in this repo are linked.
Sources: McClintock & Strong, Biblical Cyclopedia,
Contra Maximinum Arianum full text [0485].
(Feel free to adjust either
default_year/father_categoryif you prefer adifferent convention — happy to amend.)
2. Duplicate commentaries removed
Two files each contained the same commentary twice, verbatim:
Cyril of Alexandria/John 1_46.toml— the "Nathanael readily agrees…" quote appeared twice.Jerome/Genesis 10_10.toml— the "(Verse 10.) And it was, he said, the head of his kingdom…" quote appeared twice.Removed the second copy in each; one copy remains.
Thanks again for maintaining this — it's a joy to build on.